Skip to content

Add support for excluding clusters by defining a regex. #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Feb 27, 2025

Conversation

pipo02mix
Copy link
Contributor

Make optional to exclude certain clusters by ID

Towards https://gigantic.slack.com/archives/C07KSM2E51A/p1737389838683799

@pipo02mix pipo02mix requested a review from a team as a code owner January 22, 2025 15:13
@pipo02mix pipo02mix self-assigned this Jan 22, 2025
Copy link
Member

@Gacko Gacko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but consider @fiunchinho's comment. 🙂

@Gacko Gacko force-pushed the allow-cluster-exceptions branch from 8980d07 to 33e07eb Compare February 4, 2025 19:33
@Gacko
Copy link
Member

Gacko commented Feb 4, 2025

@pipo02mix Is this PR still active?

@pipo02mix
Copy link
Contributor Author

I cannot make the operatorkit version pass the tests with the changes needed. I will try this week

@Gacko Gacko force-pushed the allow-cluster-exceptions branch from 8846ecd to b659457 Compare February 27, 2025 15:08
Copy link
Member

@Gacko Gacko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a CHANGELOG entry.

@pipo02mix pipo02mix requested a review from Gacko February 27, 2025 15:11
@pipo02mix pipo02mix enabled auto-merge (squash) February 27, 2025 15:11
@Gacko Gacko force-pushed the allow-cluster-exceptions branch from 0738714 to bcf90f8 Compare February 27, 2025 15:18
@Gacko Gacko changed the title Allow cluster exceptions Add support for excluding clusters by defining a regex. Feb 27, 2025
@Gacko Gacko disabled auto-merge February 27, 2025 15:20
@Gacko Gacko enabled auto-merge (squash) February 27, 2025 15:20
@Gacko Gacko merged commit 6dc8257 into main Feb 27, 2025
6 checks passed
@Gacko Gacko deleted the allow-cluster-exceptions branch February 27, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants